lkml.org 
[lkml]   [2010]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] configfs: documentation: remove unneeded check
On Wed, Oct 27, 2010 at 12:07:35PM +0200, Dan Carpenter wrote:
> If "p" is NULL then it will cause an oops when we pass it to
> simple_strtoul(). In this case "p" can not be NULL so I removed the
> check and cleaned up the rest of the if condition as well.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> diff --git a/Documentation/filesystems/configfs/configfs_example_explicit.c b/Documentation/filesystems/configfs/configfs_example_explicit.c
> index d428cc9..63ff248 100644
> --- a/Documentation/filesystems/configfs/configfs_example_explicit.c
> +++ b/Documentation/filesystems/configfs/configfs_example_explicit.c
> @@ -89,7 +89,7 @@ static ssize_t childless_storeme_write(struct childless *childless,
> char *p = (char *) page;
>
> tmp = simple_strtoul(p, &p, 10);
> - if (!p || (*p && (*p != '\n')))
> + if (*p != '\0' && *p != '\n')
> return -EINVAL;

If you're going to prefer "*p != '\0'" to "*p" as a test, I'd
like you to include parens: "if ((*p != '\0') && (*p != '\n'))" While
the order of precedence is correct in your change, it makes folks have
to stop and think about order of precedence in the first place.

Joel

--

Life's Little Instruction Book #444

"Never underestimate the power of a kind word or deed."

Joel Becker
Senior Development Manager
Oracle
E-mail: joel.becker@oracle.com
Phone: (650) 506-8127


\
 
 \ /
  Last update: 2010-10-27 13:25    [W:2.503 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site