lkml.org 
[lkml]   [2010]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 07/30] staging/vme/tsi148: remove double freeing of the IRQ in .remove
On 26/10/10 02:10, Emilio G. Cota wrote:
> From: Emilio G. Cota <cota@braap.org>
>
> tsi148_irq_exit is called twice in .remove, which causes an oops.
>
> Remove the second call, which apart from being redundant cannot
> possibly work; the CR/CSR space has been already unmapped.
>
> Signed-off-by: Emilio G. Cota <cota@braap.org>

Acked-by: Martyn Welch <martyn.welch@ge.com>

> ---
> drivers/staging/vme/bridges/vme_tsi148.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/vme/bridges/vme_tsi148.c b/drivers/staging/vme/bridges/vme_tsi148.c
> index 660968e..acfbd59 100644
> --- a/drivers/staging/vme/bridges/vme_tsi148.c
> +++ b/drivers/staging/vme/bridges/vme_tsi148.c
> @@ -2612,8 +2612,6 @@ static void tsi148_remove(struct pci_dev *pdev)
> kfree(master_image);
> }
>
> - tsi148_irq_exit(bridge, pdev);
> -
> iounmap(bridge->base);
>
> pci_release_regions(pdev);


--
Martyn Welch (Principal Software Engineer) | Registered in England and
GE Intelligent Platforms | Wales (3828642) at 100
T +44(0)127322748 | Barbirolli Square,
Manchester,
E martyn.welch@ge.com | M2 3AB VAT:GB 927559189


\
 
 \ /
  Last update: 2010-10-27 12:05    [W:0.148 / U:11.456 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site