Messages in this thread | | | Date | Tue, 26 Oct 2010 20:00:37 -0700 | From | Dmitry Torokhov <> | Subject | Re: [PATCH 06/10] drivers/input/serio/i8042: Use pr_<level>, pr_fmt. Fix dbg and __FILE__ use |
| |
On Tue, Oct 26, 2010 at 06:35:45PM -0700, Joe Perches wrote: > On Tue, 2010-10-26 at 18:28 -0700, Dmitry Torokhov wrote: > > On Oct 26, 2010, at 6:10 PM, Joe Perches <joe@perches.com> wrote: > > > I think 2 defects in 16 uses is a pretty high error rate. > > But how not adding /n is it much better than having it if > > some later change will forget to add it to the message? > > Adding \n is the default kernel style. > > USB uses a similar dbg macro with a relatively > high error rate. > > I fixed some in this commit below awhile ago, > but these keep creeping back in, so they _are_ > error prone in actual use. >
OK, fair enough.
Thanks.
-- Dmitry
| |