Messages in this thread | | | Date | Tue, 26 Oct 2010 17:24:34 -0400 | From | "J. Bruce Fields" <> | Subject | Re: nfsd changes for 2.6.37 |
| |
On Tue, Oct 26, 2010 at 02:02:05PM -0700, Linus Torvalds wrote: > On Tue, Oct 26, 2010 at 1:55 PM, Arnd Bergmann <arnd@arndb.de> wrote: > > > > Finally, we can build fs/locks.c, nfs and nfsd with CONFIG_BKL > > disabled. > > > > *not tested* > > Ok, please make this so, so that we finally can effectively get rid of > the BKL in this release (I don't really care about the random old > drivers that may be "depends on BKL"). > > But that obviously requires at least some minimal testing by somebody > who is using NFS heavily, including locking. I assume that the > connectathon tests include file locking? And I presume that the nfs > developers run those at least semi-regularly and could do at least > that kind of minimal testing?
I did a couple connectathon runs just now with no obvious ill effects except for some sleep-within-spinlock warnings in the lease code.
Yeah, connecthon does include lock tests, though they're just basic correctness tests.
--b.
| |