Messages in this thread Patch in this message | | | Date | Tue, 26 Oct 2010 11:04:31 +0300 | Subject | Re: [PATCH] Staging: batman-adv: Remove useless braces | From | Andy Shevchenko <> |
| |
It's odd.
I've checked it before submission:
andy@fs-test:~/prj/linux-2.6(mine)$ git show 77099f0afe94928b5b0066a7efa5fa9f81696b54 | scripts/checkpatch.pl - total: 0 errors, 0 warnings, 177 lines checked
Your patch has no obvious style problems and is ready for submission.
On Tue, Oct 26, 2010 at 12:43 AM, Sven Eckelmann <sven.eckelmann@gmx.de> wrote: > 77099f0afe94928b5b0066a7efa5fa9f81696b54 added changes to vis.c which > trigger a checkpatch.pl warning about braces which are not necessary > anymore. > > WARNING: braces {} are not necessary for any arm of this statement > + if (entry->primary) > [...] > + else { > [...] > > Signed-off-by: Sven Eckelmann <sven.eckelmann@gmx.de> > Cc: Andy Shevchenko <andy.shevchenko@gmail.com> > Cc: Marek Lindner <lindner_marek@yahoo.de> > Cc: Simon Wunderlich <siwu@hrz.tu-chemnitz.de> > Cc: Andrew Lunn <andrew@lunn.ch> > --- > drivers/staging/batman-adv/vis.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/batman-adv/vis.c b/drivers/staging/batman-adv/vis.c > index 3d2c1bc..4473cc8 100644 > --- a/drivers/staging/batman-adv/vis.c > +++ b/drivers/staging/batman-adv/vis.c > @@ -135,9 +135,8 @@ static ssize_t vis_data_read_prim_sec(char *buff, struct hlist_head *if_list) > hlist_for_each_entry(entry, pos, if_list, list) { > if (entry->primary) > len += sprintf(buff + len, "PRIMARY, "); > - else { > + else > len += sprintf(buff + len, "SEC %pM, ", entry->addr); > - } > } > > return len; > -- > 1.7.2.3 > >
-- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |