lkml.org 
[lkml]   [2010]   [Oct]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 01/11] IMA: use rbtree instead of radix tree for inode information cache
    >>>>> "Linus" == Linus Torvalds <torvalds@linux-foundation.org> writes:

    Linus> On Mon, Oct 25, 2010 at 1:57 PM, Christoph Hellwig <hch@infradead.org> wrote:
    >>
    >> Kyle sent a very useful patch to simply disable the ima tracking unless
    >> you enable it on the command line.

    Linus> And exactly how does that invalidate _any_ of the patches in
    Linus> the IMA series in question? All of them are basically still
    Linus> equally valid.

    Well, if we're going to keep IMA as an option, then this cleanup is
    certainly worthwhile. And keeping it's impact down as much as
    possible is even better.

    Linus> And the "four bytes in 'struct inode' is a total no-no" crowd
    Linus> clearly haven't looked at struct inode. As mentioned, we've got
    Linus> things like quota stuff there too.

    Quota is arguably much more useful than IMA, and to a much larger
    audience. There's a reason it's in there. As a SysAdmin, one of my
    major gripes is how hard it is to manage disk space usage by my users
    and track it in useful ways.

    Quotas allow me to do a quicker, more targeted response when disk
    space fills up and I need to find the biggest users. Would I like
    better quota reporting? Sure! Do I want more overhead, not so much.
    It's a balancing act.

    Linus> And quite frankly, it sounds like the right thing to do for
    Linus> Fedora &co is to simply _disable_ CONFIG_IMA. If there is no
    Linus> support for it on a distro level, then you shouldn't enable it.

    So the Kconfig should have 'default N' for IMA then?

    John



    \
     
     \ /
      Last update: 2010-10-26 16:05    [W:2.303 / U:0.308 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site