Messages in this thread | | | Date | Tue, 26 Oct 2010 15:14:23 +0200 | From | Andi Kleen <> | Subject | Re: [PATCH] archs: add ioremap_change_write_prot |
| |
> Sorry to re-open the topic, but I'd like to receive any > comments/feedback about this patch.
The name of the wrapper seems wrong -- this has nothing to do with IO.
I must admit I'm also not a fan of wrappers, why not call the set_memory_* functions directly and implement them for the other archs too?
Other than that it seems reasonable.
-Andi
-- ak@linux.intel.com -- Speaking for myself only.
| |