Messages in this thread | | | Date | Mon, 25 Oct 2010 10:54:42 +0200 | From | Tejun Heo <> | Subject | Re: [PATCH] block: remove REQ_HARDBARRIER |
| |
On 10/23/2010 06:59 PM, Christoph Hellwig wrote: > REQ_HARDBARRIER is dead now, so remove the leftovers. What's left > at this point is: > > - various checks inside the block layer. > - sanity checks in bio based drivers. > - now unused bio_empty_barrier helper. > - Xen blockfront use of BLKIF_OP_WRITE_BARRIER - it's dead for a while, > but Xen really needs to sort out it's barrier situaton. > - setting of ordered tags in uas - dead code copied from old scsi > drivers. > - scsi different retry for barriers - it's dead and should have been > removed when flushes were converted to FS requests. > - blktrace handling of barriers - removed. Someone who knows blktrace > better should add support for REQ_FLUSH and REQ_FUA, though. > > Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks good to me.
Reviewed-by: Tejun Heo <tj@kernel.org>
Thanks.
-- tejun
| |