Messages in this thread | | | Subject | Re: [PATCH 11/29] memstick: mspro: use MS_TPC_EX_SET_CMD | From | Maxim Levitsky <> | Date | Tue, 26 Oct 2010 04:00:22 +0200 |
| |
On Mon, 2010-10-25 at 08:27 -0700, Alex Dubov wrote: > > --- On Fri, 22/10/10, Maxim Levitsky <maximlevitsky@gmail.com> wrote: > > > From: Maxim Levitsky <maximlevitsky@gmail.com> > > Subject: [PATCH 11/29] memstick: mspro: use MS_TPC_EX_SET_CMD > > To: "Alex Dubov" <oakad@yahoo.com> > > Cc: "Andrew Morton" <akpm@linux-foundation.org>, "LKML" <linux-kernel@vger.kernel.org>, "Maxim Levitsky" <maximlevitsky@gmail.com> > > Received: Friday, 22 October, 2010, 4:53 PM > > This little optimization done by Sony > > for > > PRO variant of the cards allows to bundle the param > > register > > with the command and therefore send one TPC less. > > > > This increases IO throughput somewhat. > > (4.4 -> 4.8 MB/s on Jmicron for example) > > > > 1. Names for states. > 2. Coding style. Already said that many times. It passes checkpatch.pl.
> 3. Introduction of struct mspro_cmdex_argument belongs to this patch. I won't fight over that one, but I think that its doesn't matter.
Best regards, Maxim Levitsky
| |