lkml.org 
[lkml]   [2010]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 2/3] sparc32: remove CONFIG_HAVE_PERF_EVENTS option
From
From: Namhyung Kim <namhyung@gmail.com>
Date: Tue, 26 Oct 2010 01:31:19 +0900

> 2010-10-25 (월), 08:59 -0700, David Miller:
>> From: Namhyung Kim <namhyung@gmail.com>
>> Date: Tue, 26 Oct 2010 00:52:37 +0900
>>
>> > Remove HAVE_PERF_EVENTS and PERF_USE_VMALLOC under config
>> > SPARC because they're under SPARC64 too. Supporting
>> > perf_event needs atomic64 operations but AFAIK sparc32
>> > doesn't provide them, CMIIW. ;-) Also removes redundant
>> > HAVE_IRQ_WORK line.
>> >
>> > Signed-off-by: Namhyung Kim <namhyung@gmail.com>
>>
>> The generic non-hw perf event stuff builds fine on sparc32,
>> please don't remove this unless you have a legitimate build
>> failure to report and fix.
>>
>> Even if sparc32 doesn't provide atomic64_t support, it very
>> easily could do so using include/asm-generic/atomic64.h which
>> implements them using spinlocks.
>
> Now I see following build failure without this patch. Maybe some work is
> needed to deal with atomic64_t. I'll try to prepare for it soon. Thanks.

Nevermind, I see the issue. Ok, your patch is fine:

Acked-by: David S. Miller <davem@davemloft.net>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2010-10-25 20:57    [W:0.070 / U:6.452 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site