[lkml]   [2010]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 04/29] memstick: core: rework state machines
--- On Fri, 22/10/10, Maxim Levitsky <> wrote:

> From: Maxim Levitsky <>
> Subject: [PATCH 04/29] memstick: core: rework state machines
> To: "Alex Dubov" <>
> Cc: "Andrew Morton" <>, "LKML" <>, "Maxim Levitsky" <>
> Received: Friday, 22 October, 2010, 4:53 PM
> Make state machines in memstick core
> follow the
> new style.

1. This is an important functional patch. At present, "new style" exists
only in your head. You should make an effort to justify it to everybody
else by providing a rationale in patch description.

2. You are using an integer state variable (instead of function pointers
which were self-describing by virtue of the referred function names).
Please, define an enumerated type for this state variable, giving states
human-readable, descriptive names. If you need to do state variable
arithmetic, you can provide a couple of simple, descriptive macros to
do so:

#define NEXT_STATE(s) (s + 1)

or something along the line.

3. Coding style.

 \ /
  Last update: 2010-10-25 17:05    [W:0.255 / U:5.628 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site