[lkml]   [2010]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 03/29] memstick: core: add new functions
--- On Fri, 22/10/10, Maxim Levitsky <> wrote:

> From: Maxim Levitsky <>
> Subject: [PATCH 03/29] memstick: core: add new functions
> To: "Alex Dubov" <>
> Cc: "Andrew Morton" <>, "LKML" <>, "Maxim Levitsky" <>
> Received: Friday, 22 October, 2010, 4:53 PM
> Add a lot of support code that will
> be used later.

You're adding here a lot of temporarily dead code, which, while being
useful, should be better added together with the actual driver

Besides this, the patch has a lot of unneeded clean-ups which are better
be set as a separate patch.

And it doesn't conform to the coding guideline either (4 byte indents,
instead of tabs).

 \ /
  Last update: 2010-10-25 16:59    [W:0.198 / U:1.252 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site