lkml.org 
[lkml]   [2010]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/2] Export usb_serial_generic_write_room for use in modules
On Sat, Oct 23, 2010 at 08:43:28PM +0200, Alon Ziv wrote:
> Any module using usb_serial_generic_write (which is already exported)
> had better use usb_serial_generic_write_room as well, or be prepared
> for failures.

As I mentioned elsewhere, this description is a little misleading as any
driver can use the generic write_room implementation simply by not
overriding it (i.e. leaving the write_room field undefined).

There is nothing wrong with exporting it, but it is currently only your
other patch that requires that. Could you perhaps just modify the patch
description?

Thanks,
Johan


\
 
 \ /
  Last update: 2010-10-25 13:23    [W:0.092 / U:1.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site