lkml.org 
[lkml]   [2010]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 04/15] x86, apic: Remove early_init_lapic_mapping
    On Sat, 23 Oct 2010, Yinghai Lu wrote:

    > It is almost the same as smp_register_lapic_addr()
    >
    > Just need to make smp_read_mpc() call smp_register_lapic_addr when early==1.

    > @@ -289,17 +289,13 @@ static int __init smp_read_mpc(struct mpc_table *mpc, unsigned early)
    > #ifdef CONFIG_X86_32
    > generic_mps_oem_check(mpc, oem, str);
    > #endif
    > - /* save the local APIC address, it might be non-default */
    > + /* Initialize the lapic mapping */
    > if (!acpi_lapic)
    > - mp_lapic_addr = mpc->lapic;
    > + smp_register_lapic_address(mpc->lapic);

    How is this restricted to early == 1 ? It's called unconditionally
    which is nonsense.

    Thanks,

    tglx


    \
     
     \ /
      Last update: 2010-10-24 11:57    [W:0.024 / U:29.648 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site