lkml.org 
[lkml]   [2010]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 02/15] x86, apic: Fix lapic mapping with construct ISA and visws mptable path
    On Sat, 23 Oct 2010, Yinghai Lu wrote:

    > Do need to set lapic mapping for them
    >
    > in arch/x86/kernel/visws_quirks.c:
    > we only have visws_find_smp_config() to set mp_lapic_addr to APIC_DEFAULT_PHYS_BASE
    > visws_get_smp_config() is nop call.
    > default_get_smp_config/check_physptr/smp_read_mpc is not called in the path.
    > So smp_register_lapic_address() is not called, and lapic is not mapped.

    -ENOPARSE. visws maps the APIC itself already in cobalt_init()

    > in arch/x86/kernel/mpparse.c
    > if mpf->feature1 != 0, it will go through contruct_default_ISA_mptable instead
    > of check_phystr path, so smp_register_lapic_address is not called.
    >
    > Those pathes all have smp_found_config set.
    >
    > So need to remove !smp_found_config checking

    Need ? You can, because the check is redundant if I understand the
    above correctly.

    Thanks,

    tglx

    > Signed-off-by: Yinghai Lu <yinghai@kernel.org>
    > ---
    > arch/x86/kernel/apic/apic.c | 2 +-
    > 1 files changed, 1 insertions(+), 1 deletions(-)
    >
    > diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c
    > index 4638396..193e407 100644
    > --- a/arch/x86/kernel/apic/apic.c
    > +++ b/arch/x86/kernel/apic/apic.c
    > @@ -1677,7 +1677,7 @@ void __init init_apic_mappings(void)
    > * acpi lapic path already maps that address in
    > * acpi_register_lapic_address()
    > */
    > - if (!acpi_lapic && !smp_found_config)
    > + if (!acpi_lapic)
    > set_fixmap_nocache(FIX_APIC_BASE, apic_phys);
    >
    > apic_printk(APIC_VERBOSE, "mapped APIC to %08lx (%08lx)\n",
    > --
    > 1.7.1
    >


    \
     
     \ /
      Last update: 2010-10-24 11:51    [W:0.026 / U:0.544 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site