Messages in this thread | | | Date | Sun, 24 Oct 2010 10:37:19 +0200 | From | Lothar Waßmann <> | Subject | RE: [PATCHv5 2/3] ARM: imx: Add gpio-keys to plat-mxc |
| |
Hi, > >> How do you suggest I define this pin for Babbage board only? Do I add to iomux-mx51.h > >> #define MX51_BABBAGE_PAD_EIM_A27__GPIO_2_21 IOMUX_PAD(0x45c, 0x0c8, 1, 0x0, > >0,MX51_GPIO_PAD_CTRL | PAD_CTL_PUS_100K_UP) ? > >> > >> Or do I define the pin in the board file with a 100K_UP? Like how eukrea_mbimxsd-baseboard.c did for > >MBIMXSD_GPIO_3_31? > >I'd suggest something local to your machine file. Unfortunately I don't > >see an easy way to reuse the generic MX51_PAD_EIM_A27__GPIO_2_21 to > >define your local symbol. So I think something like you wrote above > >should be fine. > > > >Too bad that > > > > #define MX51_BABBAGE_PAD_EIM_A27__GPIO_2_21 (MX51_PAD_EIM_A27__GPIO_2_21 | PAD_CTL_PUS_100K_UP) > > > >doesn't work. > > Yes, I also wish I didn't have to redefine the pin just because of PAD setting change. I am going to send out another patch that basically sets the pad_desc.pad_ctrl=PAD_SETTING in mxc_init_board() function. I think it's a bit cleaner than having to redefine the pin. > IMO the 'struct pad_desc' should be replaced with an u64 bitmap that would allow for the pullup and other definitions that may be board specific to be simply or'ed to the pad definition.
I could try to provide a patch if this is agreed on.
Lothar Waßmann -- ___________________________________________________________
Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10 Geschäftsführer: Matthias Kaussen Handelsregistereintrag: Amtsgericht Aachen, HRB 4996
www.karo-electronics.de | info@karo-electronics.de ___________________________________________________________ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |