lkml.org 
[lkml]   [2010]   [Oct]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 04/21] fs: Implement lazy LRU updates for inodes
    On Thu, Oct 21, 2010 at 11:49:29AM +1100, Dave Chinner wrote:
    > if (sb->s_flags & MS_ACTIVE) {
    > + inode->i_state |= I_REFERENCED;
    > + if (!(inode->i_state & (I_DIRTY|I_SYNC))) {
    > + list_del_init(&inode->i_list);
    > + inode_lru_list_add(inode);

    What if it was on the list already? Looks like you'll screw the counter...
    And yes, you have solution later in series (do nothing if list isn't empty);
    should be here for bisectability sake...


    \
     
     \ /
      Last update: 2010-10-23 11:35    [W:0.021 / U:30.592 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site