Messages in this thread | | | Date | Fri, 22 Oct 2010 10:05:35 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH v2][GIT PULL] tracing: Prevent unloadable modules from using trace_bprintk() |
| |
* Steven Rostedt <rostedt@goodmis.org> wrote:
> > Ingo, > > This is based off of my core-2 branch. I'm moved this patch after that > so if anyone has any objections, I can change this patch without holding > off the previous one. > > Note, I made the TRACE_BPRINTK_ALLOWED change since it looks better.
Hm, it still looks rather fundamentally ugly, messy and assymetric. Please work out some better solution with the module folks. If there's really no sane solution then we better remove this 'speedup' API, it's just not worth it.
Thanks,
Ingo
| |