Messages in this thread Patch in this message | | | From | Jason Wessel <> | Subject | [PATCH 06/11] kdb: Fix oops in kdb_unregister | Date | Fri, 22 Oct 2010 15:56:26 -0500 |
| |
Nothing should try to use kdb_commands directly as sometimes it is null. Instead, use the for_each_kdbcmd() iterator.
This particular problem dates back to the initial kdb merge (2.6.35), but at that point nothing was dynamically unregistering commands from the kdb shell.
Signed-off-by: Jason Wessel <jason.wessel@windriver.com> --- kernel/debug/kdb/kdb_main.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kernel/debug/kdb/kdb_main.c b/kernel/debug/kdb/kdb_main.c index 5448990..4226f32 100644 --- a/kernel/debug/kdb/kdb_main.c +++ b/kernel/debug/kdb/kdb_main.c @@ -2826,7 +2826,7 @@ int kdb_unregister(char *cmd) /* * find the command. */ - for (i = 0, kp = kdb_commands; i < kdb_max_commands; i++, kp++) { + for_each_kdbcmd(kp, i) { if (kp->cmd_name && (strcmp(kp->cmd_name, cmd) == 0)) { kp->cmd_name = NULL; return 0; -- 1.6.3.3
| |