lkml.org 
[lkml]   [2010]   [Oct]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[53/66] b44: fix carrier detection on bind
    2.6.32-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Paul Fertser <fercerpav@gmail.com>

    commit bcf64aa379fcadd074449cbf0c049da70071b06f upstream.

    For carrier detection to work properly when binding the driver with a cable
    unplugged, netif_carrier_off() should be called after register_netdev(),
    not before.

    Signed-off-by: Paul Fertser <fercerpav@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/net/b44.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/drivers/net/b44.c
    +++ b/drivers/net/b44.c
    @@ -2175,8 +2175,6 @@ static int __devinit b44_init_one(struct
    dev->irq = sdev->irq;
    SET_ETHTOOL_OPS(dev, &b44_ethtool_ops);

    - netif_carrier_off(dev);
    -
    err = ssb_bus_powerup(sdev->bus, 0);
    if (err) {
    dev_err(sdev->dev,
    @@ -2216,6 +2214,8 @@ static int __devinit b44_init_one(struct
    goto err_out_powerdown;
    }

    + netif_carrier_off(dev);
    +
    ssb_set_drvdata(sdev, dev);

    /* Chip reset provides power to the b44 MAC & PCI cores, which



    \
     
     \ /
      Last update: 2010-10-22 20:49    [W:0.018 / U:0.496 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site