Messages in this thread | | | From | "Guzman Lugo, Fernando" <> | Date | Fri, 22 Oct 2010 11:23:34 -0500 | Subject | RE: [PATCHv4 4/4] iommu: create new api to set valid da range |
| |
> -----Original Message----- > From: Felipe Contreras [mailto:felipe.contreras@gmail.com] > Sent: Friday, October 22, 2010 4:59 AM > To: Guzman Lugo, Fernando > Cc: Hiroshi.DOYU@nokia.com; felipe.contreras@nokia.com; > david.cohen@nokia.com; linux-kernel@vger.kernel.org; > linux-omap@vger.kernel.org > Subject: Re: [PATCHv4 4/4] iommu: create new api to set valid da range > > On Wed, Oct 20, 2010 at 7:26 PM, Felipe Contreras > <felipe.contreras@gmail.com> wrote: > > On Wed, Oct 20, 2010 at 6:22 PM, Guzman Lugo, Fernando > > <fernando.lugo@ti.com> wrote: > >>> On Wed, Oct 20, 2010 at 5:48 AM, Fernando Guzman Lugo > >>> <x0095840@ti.com> wrote: > >>> > Some IOMMUs cannot use the whole 0x0 - 0xFFFFFFFF range. > >>> > With this new API the valid range can be set. > >>> > > >>> > Signed-off-by: Fernando Guzman Lugo <x0095840@ti.com> > >>> > >>> I don't see the point in having an API. It could be done > >> > >> Thanks to this api we can make this: > >> > >> A new kconfig parameter for DMM size is added. Also DMM is > allocated > >> in the last part of the IVA MMU capable address. > >> So that DMM address are far away of shared memory address reducing > >> the probability of shared memory corruption. > > > > Ok, that's why it's usually a good idea to send a patch > that makes use > > of the new API. > > Oh, and some more comments: Hiroshi wanted the end address > too, but also on the platform data.
I will try that.
> > And please use a sensible prefix, like "omap: iommu: ", if you only do > "iommu: " it can be confused with other parts of the system, > specially if you send to lkml.
Sure, I wil take care for that.
Thanks and regards, Fernando.
> > -- > Felipe Contreras >
| |