Messages in this thread Patch in this message | | | Date | Fri, 22 Oct 2010 11:43:16 -0400 | From | Dean Nelson <> | Subject | [PATCH] Add missing spin_lock() to hugetlb_cow() |
| |
Add missing spin_lock() of the page_table_lock before an error return in hugetlb_cow(). Callers of hugtelb_cow() expect it to be held upon return.
Signed-off-by: Dean Nelson <dnelson@redhat.com> CC: stable@kernel.org
---
Sorry for the noise, if there has already been a patch posted to fix this issue. I didn't see one.
mm/hugetlb.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/mm/hugetlb.c b/mm/hugetlb.c index c032738..8ee804b 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c @@ -2380,8 +2380,11 @@ retry_avoidcopy: * When the original hugepage is shared one, it does not have * anon_vma prepared. */ - if (unlikely(anon_vma_prepare(vma))) + if (unlikely(anon_vma_prepare(vma))) { + /* Caller expects lock to be held */ + spin_lock(&mm->page_table_lock); return VM_FAULT_OOM; + } copy_huge_page(new_page, old_page, address, vma); __SetPageUptodate(new_page);
| |