Messages in this thread | | | Date | Fri, 22 Oct 2010 08:30:07 -0700 | From | Mark Brown <> | Subject | Re: [PATCH] regulator: twl-regulator - fix twlreg_set_mode |
| |
On Fri, Oct 22, 2010 at 04:38:22PM +0800, Axel Lin wrote: > The Singular Message is 16 bits: > DEV_GRP[15:13] MT[12] RES_ID[11:4] RES_STATE[3:0] > > Current implementation return immedially after sucessfuly write MSB part. > To properly set mode, we need to write the complete message ( MSB and LSB ). > > In twl.h, now we have defines for PM Master module register offsets, > use it instead of hard coded 0x15/0x16. > > Use "message & 0xff" to ensure we send correct value for LSB. > > Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> I don't have this hardware handy, I appreciate if someone who has the > hardware can test this patch.
I beleive Liam has appropriate hardware.
| |