lkml.org 
[lkml]   [2010]   [Oct]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] rivafb: dubious assignment
    From
    On Fri, Oct 22, 2010 at 13:31, Nicolas Kaiser <nikai@nikai.net> wrote:
    > A duplicated assignment unconditionally changes max_gfsize to
    > GFIFO_SIZE.
    >
    > It looks to me like this might not be intended, or is it?
    >
    > Signed-off-by: Nicolas Kaiser <nikai@nikai.net>
    > ---
    >  drivers/video/riva/riva_hw.c |    1 -
    >  1 files changed, 0 insertions(+), 1 deletions(-)
    >
    > diff --git a/drivers/video/riva/riva_hw.c b/drivers/video/riva/riva_hw.c
    > index 78fdbf5..936abfa 100644
    > --- a/drivers/video/riva/riva_hw.c
    > +++ b/drivers/video/riva/riva_hw.c
    > @@ -263,7 +263,6 @@ static int nv3_iterate(nv3_fifo_info *res_info, nv3_sim_state * state, nv3_arb_i
    >     vmisses = 2;
    >     if (ainfo->gburst_size == 128) max_gfsize = GFIFO_SIZE_128;
    >     else  max_gfsize = GFIFO_SIZE;
    > -    max_gfsize = GFIFO_SIZE;
    >     while (1)
    >     {
    >         if (ainfo->vid_en)
    > --
    > 1.7.2.2

    According to full-history-linux, this comes from the initial drop in 2.3.49pre2,
    from nVidia code(?), imported by Jeff Garzik.

    Gr{oetje,eeting}s,

                            Geert

    --
    Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

    In personal conversations with technical people, I call myself a hacker. But
    when I'm talking to journalists I just say "programmer" or something like that.
                                    -- Linus Torvalds
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-10-22 16:49    [W:0.025 / U:147.412 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site