Messages in this thread | | | Date | Fri, 22 Oct 2010 16:34:16 +0200 | From | Jörn Engel <> | Subject | Re: [PATCH] block2mtd: dubious assignment |
| |
On Fri, 22 October 2010 12:47:24 +0200, Nicolas Kaiser wrote: > > When block2mtd_erase fails, a duplicated assignment instantly > changes instr->state from MTD_ERASE_FAILED to MTD_ERASE_DONE. > > It looks to me like this might not be intended, or is it?
Definitely not. Just proves how well block device errors are tested.
> Signed-off-by: Nicolas Kaiser <nikai@nikai.net> Acked-By: Joern Engel <joern@logfs.org>
Artem, can I leave this patch to you as well?
Jörn
-- Eighty percent of success is showing up. -- Woody Allen -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |