lkml.org 
[lkml]   [2010]   [Oct]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 10/12] backlight: add support for tps6116x controller
From
Date
On Thu, 2010-10-21 at 17:01 -0400, Cyril Chemparathy wrote:
> diff --git a/drivers/video/backlight/tps6116x.c b/drivers/video/backlight/tps6116x.c

just some trivia:

> @@ -0,0 +1,340 @@
[]
> +struct tps6116x {
> + struct ti_ssp_device *handle;
> + struct device *dev;
> + int gpio, gpio_initialized;
> + struct mutex lock;
> + int intensity;
> + int power;
> + struct backlight_properties props;
> + struct backlight_device *bl;
> + int suspended:1;
> + struct regulator *regulator;
> +};

Perhaps several of these should be bool.
gpio_initialized, power, suspended

[]

> +static int __devinit tps6116x_probe(struct platform_device *pdev)
> +{
> + struct tps6116x *hw;
> + struct device *dev = &pdev->dev;
> + struct backlight_properties props;
> + int error;
> +
> + hw = kzalloc(sizeof(struct tps6116x), GFP_KERNEL);
> + if (!hw) {
> + error = -ENOMEM;
> + dev_err(dev, "cannot allocate driver data\n");
> + goto fail0;
> + }
> + platform_set_drvdata(pdev, hw);
> +
> + memset(hw, 0, sizeof(struct tps6116x));

Unnecessary memset.




\
 
 \ /
  Last update: 2010-10-21 23:21    [W:0.114 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site