lkml.org 
[lkml]   [2010]   [Oct]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Make div64_u64() precise on 32bit platforms
On Thu, 21 Oct 2010 20:12:20 +0200
Oleg Nesterov <oleg@redhat.com> wrote:

> Andrew, please drop
>
> lib-div64c-document-that-div64_u64-is-not-precise-on-32bit-platforms.patch
>
> On 10/21, Brian Behlendorf wrote:
> >
> > I think we should use your simpler version. There's no good reason to
> > make this more complicated than it needs to be. I haven't been able to
> > find a test case where your changes get the wrong result.
>
> Great!
>
> > From: Brian Behlendorf <behlendorf1@llnl.gov>
> > Date: Thu, 5 Aug 2010 14:59:11 -0700
> > Subject: [PATCH] Fix div64_u64 for 32bit platforms
> >
> > The current implementation of div64_u64 for 32bit systems returns
> > an approximately correct result when the divisor exceeds 32bits.
> > Since doing 64bit division using 32bit hardware is a long since
> > solved problem we just use one of the existing proven methods.
>
> Brian, you forgot to add your sob. Hopefully Andrew can add
>
> Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
>
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>

OK..

Just to tie all this off, you originally said "We have a bug report
which blames div64_u64() on 32bit platforms.". Where is that bug report?

Thanks.


\
 
 \ /
  Last update: 2010-10-21 21:25    [W:0.048 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site