lkml.org 
[lkml]   [2010]   [Oct]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] POWER: Add gpio chager driver
On Thu, Oct 21, 2010 at 04:52:37PM +0200, Lars-Peter Clausen wrote:
[...]
> >> + gpio_charger->irq = gpio_to_irq(pdata->gpio);
> >> + if (gpio_charger->irq >= 0) {
> >
> > 0 isn't valid IRQ number. The check should be just 'if (gpio_charger->irq)'.
>
> While it is unlikely to be used for an gpio IRQ, as far as I know 0 is a valid IRQ
> number.

0 may be a valid HW IRQ, but not VIRQ.

http://www.mail-archive.com/linuxppc-dev@lists.ozlabs.org/msg22857.html

Thanks,

--
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2


\
 
 \ /
  Last update: 2010-10-21 17:09    [W:0.071 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site