Messages in this thread | | | Date | Thu, 21 Oct 2010 19:05:54 +0400 | From | Anton Vorontsov <> | Subject | Re: [PATCH] POWER: Add gpio chager driver |
| |
On Thu, Oct 21, 2010 at 04:52:37PM +0200, Lars-Peter Clausen wrote: [...] > >> + gpio_charger->irq = gpio_to_irq(pdata->gpio); > >> + if (gpio_charger->irq >= 0) { > > > > 0 isn't valid IRQ number. The check should be just 'if (gpio_charger->irq)'. > > While it is unlikely to be used for an gpio IRQ, as far as I know 0 is a valid IRQ > number.
0 may be a valid HW IRQ, but not VIRQ.
http://www.mail-archive.com/linuxppc-dev@lists.ozlabs.org/msg22857.html
Thanks,
-- Anton Vorontsov email: cbouatmailru@gmail.com irc://irc.freenode.net/bd2
| |