Messages in this thread Patch in this message | | | Subject | [PATCH][GIT PULL] tracing: Do not limit the size of the number of CPU buffers | From | Steven Rostedt <> | Date | Thu, 21 Oct 2010 09:40:26 -0400 |
| |
Ingo,
I rebased my tree. This one removed the trace_bprintk() from modules patch, since it may be questionable. But to not keep this patch from being pulled, I put it separately. I'll post a core-3 soon with the trace_bprintk() patch as well.
-- Steve
Please pull the latest tip/perf/core-2 tree, which can be found at:
git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-2.6-trace.git tip/perf/core-2
Steven Rostedt (1): tracing: Do not limit the size of the number of CPU buffers
---- kernel/trace/trace.c | 8 ++------ 1 files changed, 2 insertions(+), 6 deletions(-) --------------------------- commit dd49a38cf30944be27892c10b1c0e5b3fa73bcb2 Author: Steven Rostedt <srostedt@redhat.com> Date: Wed Oct 20 21:51:26 2010 -0400
tracing: Do not limit the size of the number of CPU buffers The tracing per_cpu buffers were limited to 999 CPUs for a mear savings in stack space of a char array. Up the array to 30 characters which is more than enough to hold a 64 bit number. Reported-by: Robin Holt <holt@sgi.com> Suggested-by: Ingo Molnar <mingo@elte.hu> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index 001bcd2..82d9b81 100644 --- a/kernel/trace/trace.c +++ b/kernel/trace/trace.c @@ -3996,13 +3996,9 @@ static void tracing_init_debugfs_percpu(long cpu) { struct dentry *d_percpu = tracing_dentry_percpu(); struct dentry *d_cpu; - /* strlen(cpu) + MAX(log10(cpu)) + '\0' */ - char cpu_dir[7]; + char cpu_dir[30]; /* 30 characters should be more than enough */ - if (cpu > 999 || cpu < 0) - return; - - sprintf(cpu_dir, "cpu%ld", cpu); + snprintf(cpu_dir, 30, "cpu%ld", cpu); d_cpu = debugfs_create_dir(cpu_dir, d_percpu); if (!d_cpu) { pr_warning("Could not create debugfs '%s' entry\n", cpu_dir);
| |