Messages in this thread | | | Date | Thu, 21 Oct 2010 02:48:34 +0400 | Subject | Re: [PATCH 2/6] serial: Add support for UART on VIA VT8500 and compatibles | From | Alexey Charkov <> |
| |
2010/10/21 Greg KH <gregkh@suse.de>: > On Thu, Oct 21, 2010 at 01:31:41AM +0400, Alexey Charkov wrote: >> 2010/10/21 Greg KH <gregkh@suse.de>: >> > On Thu, Oct 21, 2010 at 12:55:34AM +0400, Alexey Charkov wrote: >> >> This adds a driver for the serial ports found in VIA and WonderMedia >> >> Systems-on-Chip. Interrupt-driven FIFO operation is implemented. >> >> The hardware also supports pure register-based operation (which is >> >> slower) and DMA-based FIFO operation. As the FIFOs are only 16 bytes >> >> long, DMA operation is probably not worth the hassle. >> >> >> >> Signed-off-by: Alexey Charkov <alchark@gmail.com> >> >> --- >> >> >> >> Please review and state whether this could be acceptable for a merge >> >> to mainline in the coming 2.6.37 window. >> > >> > .37? ??Aren't you cutting it a bit close here? ??My trees unofficially >> > closed a few days or so ago for new stuff to go to .37, what kept this >> > from being sent previously? >> > >> >> In fact, I'm somewhat new to kernel development, and have not yet >> understood the good timings to do things properly. > > Please read the information in Documentation/development_process, it > will help you out a lot. > >> My view was that the merge window is when new stuff should be >> submitted, while everything in between is devoted to fixing breakage >> just introduced. So, I must have been wrong :) > > The merge window is for the subsystem maintainers, not the individual > developers. You need to have the code into a subsystem tree before the > merge window in order to be able to get it accepted. > >> >> If possible, I would deeply appreciate a merge to a relevant git tree >> >> for integration prior to asking Linus to pull the changes. I could >> >> rebase the code if needed, currently this is against Linus' master >> >> branch. >> >> >> >> This patch relies on the basic architecture support for VT8500/WM8505 >> >> to be in place, as introduced by PATCH 1/6 in this series. >> > >> > So it will just fail to build without that patch? >> > >> >> It won't, and it should not even be selectable, as there is a Kconfig >> dependency on the relevant arch. It's just that it would be useless >> without the relevant arch support. > > That's good to know. > > As the .37 merge window just opened, you are going to have to wait until > 2.6.37-rc1 before anyone will be able to have the time to review and > accept these patches, sorry. Please resend them then. > > thanks, > > greg k-h >
Thanks for the directions, Greg! Probably we will have more things to submit by then, so it does not really hurt.
Best regards, Alexey -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |