[lkml]   [2010]   [Oct]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [patch 19/35] fs: icache remove redundant i_sb_list umount locking
On Tue, Oct 19, 2010 at 02:42:35PM +1100, wrote:
> + /*
> + * We can walk the per-sb list of inodes here without worrying about
> + * its consistency, because the list must not change during umount
> + * anymore, and because iprune_sem keeps shrink_icache_memory() away.
> + */
> fsnotify_unmount_inodes(&sb->s_inodes);

OK, explain to me why is that safe. Note that fsnotify_destroy_mark()
_can_ race with umount, dropping the last reference to inode before
fsnotify_unmount_inodes() would get to it and kill it (along with the mark).
With the current code it's just fine - we walk the list under lock and
iput() won't mess with that list until it acquires the damn lock. And
no matter who gets there first, the mark will be destroyed and reference
to inode will be dropped.

With your change, AFAICS, removal from the list can happen while we walk
it. With obvious results.

 \ /
  Last update: 2010-10-20 14:49    [W:0.170 / U:0.884 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site