lkml.org 
[lkml]   [2010]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] drivers/hwmon: Use pr_fmt and pr_<level>
    On Tue, Oct 19, 2010 at 11:34:18PM -0400, Joe Perches wrote:
    > On Tue, 2010-10-19 at 20:29 -0700, Guenter Roeck wrote:
    > > On Tue, Oct 19, 2010 at 07:13:40PM -0400, Joe Perches wrote:
    > > > Convert printks to pr_<level>
    > > > Coalesce long formats
    > > > Removed prefixes from formats
    > > > Added #define pr_fmt KBUILD_MODNAME ": " fmt
    > > > Standardized abitguru messages for reporting and finding MAINTAINER
    > > > Compiled x86 allyesconfig only.
    > > > I inspected "strings drivers/hwmon/built-in.o",
    > > > but it's otherwise untested.
    > > > Signed-off-by: Joe Perches <joe@perches.com>
    > > There are several lines longer than 80 characters.
    > > Does this rule no longer apply ?
    >
    > 80 columns isn't checked for printk format strings.
    >
    Interesting.

    > A kernel general preference may be to keep formats as
    > a single string without line breaks so that grep works
    > better.
    >
    > > Oddly enough, there are only four checkpatch warnings about long lines,
    > > even though there are many more.
    >
    > The version I use doesn't show any warnings.
    >
    checkpatch.pl from both v2.6.36-rc7 and v2.6.36-rc6 do report warnings.
    Looks like those versions flag long lines for pr_warn. Is your version
    older or newer ?

    Anyway, would it be possible to split the patch into one patch per file ?

    I don't know how Jean thinks about it, but in my opinion it would be cleaner,
    permit revert on a single patch/file instead of having to revert the entire series,
    it would simplify review, and it would make it much easier to cherry-pick
    pieces into other releases if needed.

    Thanks,
    Guenter


    \
     
     \ /
      Last update: 2010-10-20 05:57    [W:0.022 / U:0.628 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site