lkml.org 
[lkml]   [2010]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/6] IMA: use rbtree instead of radix tree for inode information cache
On Tue, Oct 19, 2010 at 06:58:39PM -0400, Eric Paris wrote:
> @@ -36,12 +63,11 @@ struct ima_iint_cache *ima_iint_find_get(struct inode *inode)
> struct ima_iint_cache *iint;
>
> rcu_read_lock();
> - iint = radix_tree_lookup(&ima_iint_store, (unsigned long)inode);
> - if (!iint)
> - goto out;
> - kref_get(&iint->refcount);
> -out:
> + iint = __ima_iint_find(inode);
> + if (iint)
> + kref_get(&iint->refcount);
> rcu_read_unlock();
> +

This is wrong - the rbtree is protected only by the ima_iint_lock(),
not RCU. Hence you can't do lockless lookups on an rbtree in this
manner as they will race with inserts and deletes.

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com


\
 
 \ /
  Last update: 2010-10-20 01:21    [W:0.070 / U:0.440 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site