lkml.org 
[lkml]   [2010]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v3] Bluetooth: btwilink driver
    * Savoy, Pavan <pavan_savoy@ti.com> [2010-10-20 02:15:29 +0530]:

    >
    >
    >
    > > -----Original Message-----
    > > From: Gustavo F. Padovan [mailto:pao@profusion.mobi] On Behalf Of Gustavo F.
    > > Padovan
    > > Sent: Tuesday, October 19, 2010 3:39 PM
    > > To: Savoy, Pavan
    > > Cc: marcel@holtmann.org; linux-bluetooth@vger.kernel.org; linux-
    > > kernel@vger.kernel.org
    > > Subject: Re: [PATCH v3] Bluetooth: btwilink driver
    > >
    > > * pavan_savoy@ti.com <pavan_savoy@ti.com> [2010-10-19 16:57:38 -0400]:
    > >
    > > > From: Pavan Savoy <pavan_savoy@ti.com>
    > > >
    > > > v3 comments
    > > >
    > > > Marcel, Gustavo, & list,
    > > > Please review this version of patch.
    > > >
    > > > Anderson,
    > > > I have taken care of most of the comments you had.
    > > > Have re-wrote some of the code commenting you've mentioned.
    > > > Thanks for the comments,
    > > >
    > > > The other few like -EPERM for platform driver registration is to keep
    > > > it similar to other drivers
    > >
    > > Which drivers returns -EPERM to any kind of error? The are many reasons
    > > why the funcion can fail, and you want to give the best error report to the
    > > user. Use EPERM to all of them is just wrong.
    >
    > Yes, it can fail for plenty of reasons.
    > So I'll just return whatever I get from platform_driver_register.
    > Is this OK?

    Yes.

    >
    > > >type casting is maintained just to feel safe
    > > > and have style similar to other drivers.
    > >
    > > We don't need to feel safe here. Type cast actually can hide errors,
    > > only use them when you really need to cast, in many case here you don't.
    >
    > Ok, I can remove type casting.
    > I am not really for or against it...

    Yes, do that please. ;)


    --
    Gustavo F. Padovan
    ProFUSION embedded systems - http://profusion.mobi


    \
     
     \ /
      Last update: 2010-10-19 22:57    [W:0.023 / U:0.496 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site