lkml.org 
[lkml]   [2010]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 1/3] drivers: misc: add omap_hwspinlock driver
    Date
    On Monday 18 October 2010 09:44:33 Ohad Ben-Cohen wrote:
    > + int omap_hwspin_lock(struct omap_hwspinlock *hwlock, unsigned long *flags);
    > ...
    > + The flags parameter is a pointer to where the interrupts state of the
    > + caller will be saved at.

    This seems to encourage sloppy coding: The only variant you allow is the one
    that corresponds to Linux's spin_lock_irqsave(), which is generally discouraged
    in all places where you know if you need to disable interrupts or not.

    IMHO the default should be a version that only allows locks that don't get
    taken at IRQ time and consequently don't require saving the interrupt flags.

    Arnd


    \
     
     \ /
      Last update: 2010-10-19 19:23    [W:4.058 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site