Messages in this thread | | | Date | Tue, 19 Oct 2010 09:28:44 -0400 | From | Neil Horman <> | Subject | Re: Linux 2.6.35/TIPC 2.0 ABI breaking changes |
| |
On Tue, Oct 19, 2010 at 10:19:36AM -0300, Leandro Lucarella wrote: > Neil Horman, el 19 de octubre a las 07:04 me escribiste: > > On Tue, Oct 19, 2010 at 01:16:49AM -0700, David Miller wrote: > > > From: Leandro Lucarella <luca@llucax.com.ar> > > > Date: Mon, 18 Oct 2010 23:16:57 -0300 > > > > > > > > > > > The problem is not between the tipc stacks in different hosts, is > > > > between the tipc stack and the applications using it (well, maybe > > > > there is a problem somewhere else too). > > > > > > > > This was a deliberate API change, not a subtle bug... > > > > > > Neil et al., if these packets live only between the kernel stack > > > and the userspace API layer, we should not be byte-swapping this > > > stuff and we need to fix this fast. > > > > > Copy that Dave. I think I see the problem. The subscription code handles > > messages both off the wire and from local user space. The off the wire case > > should work because the subscription code assumes that all the incomming data is > > in network byte order, but user space is an exception to that rule as its in > > local byte order. I'll have a patch together for Leandro to test soon. > > Neil > > Thank you very much. Bare in mind that the byte order is just one of the > problems, the other problem is the change in the value of > TIPC_SUB_SERVICE from 2 to 0. That too is breaking the API/ABI, as > a message with a filter value of 2 is rejected by TIPC 2.0/2.6.35+. > Yeah, that was the format change. We might just need to revert that. Lets see about getting the endianess issue straight, and we'll go from there. Neil
> -- > Leandro Lucarella (AKA luca) http://llucax.com.ar/ > ---------------------------------------------------------------------- > GPG Key: 5F5A8D05 (F8CD F9A7 BF00 5431 4145 104C 949E BFB6 5F5A 8D05) > ---------------------------------------------------------------------- > Dentro de 30 años Argentina va a ser un gran supermercado con 15 > changuitos, porque esa va a ser la cantidad de gente que va a poder > comprar algo. > -- Sidharta Wiki > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |