lkml.org 
[lkml]   [2010]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] tracing: Cleanup the convoluted softirq tracepoints
From
Date
On Tue, 2010-10-19 at 15:00 +0200, Thomas Gleixner wrote:
>
> With the addition of trace_softirq_raise() the softirq tracepoint got
> even more convoluted. Why the tracepoints take two pointers to assign
> an integer is beyond my comprehension.
>
> But adding an extra case which treats the first pointer as an unsigned
> long when the second pointer is NULL including the back and forth
> type casting is just horrible.
>
> Convert the softirq tracepoints to take a single unsigned int argument
> for the softirq vector number and fix the call sites.
>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>

A much needed cleanup indeed!


\
 
 \ /
  Last update: 2010-10-19 15:11    [from the cache]
©2003-2011 Jasper Spaans