Messages in this thread | | | Date | Tue, 19 Oct 2010 13:52:10 +0300 | Subject | Re: [PATCH 3/3] drivers: cleanup Kconfig stuff | From | Felipe Contreras <> |
| |
On Tue, Oct 19, 2010 at 1:12 PM, Felipe Balbi <balbi@ti.com> wrote: > On Tue, Oct 19, 2010 at 04:55:04AM -0500, Felipe Contreras wrote: >> >> I'm not talking about phonet, I replied to your comment regarding >> USB_GADGET_MUSB_HDRC. For me USB_GADGET_MUSB_HDRC=n USB_G_NOKIA=y >> doesn't work, but the Kconfig allows it. > > I see, that's a problem for sure. > >> Ok, I'll make it: depends on (NOP_USB_XCEIV || TWL4030_USB) >> >> BTW, if you want to try this: >> ./scripts/kconfig/conf --defconfig=usb_defconfig arch/arm/Kconfig >> >> usb_defconfig: >> CONFIG_ARCH_OMAP=y >> CONFIG_EXPERIMENTAL=y >> CONFIG_NET=y >> CONFIG_PHONET=y >> >> CONFIG_USB=y >> CONFIG_USB_GADGET=y >> CONFIG_USB_MUSB_OTG=y >> CONFIG_USB_MUSB_HDRC=y >> CONFIG_USB_G_NOKIA=y >> >> # TODO USB_MUSB_OTG should select this >> CONFIG_USB_GADGET_MUSB_HDRC=y >> >> I expect TWL4030_USB and USB_OTG to be automatically selected. > > could be, but that's a board-by-board thing. It's not mandatory to have > twl4030-usb, it's mandatory to have a transceiver, not matter which one > it is.
I see, but is it possible that in a board you have the two? If not, there must be a way to find the correct transceiver based on the configuration. If yes, then there must be a way to select a sensible one by default, rather than not having any.
This way, for example it would be possible to get rid of some lines in a minimal n900_defconfig (used in MeeGo[1]), and eventually hopefully get rid of all of them (except CONFIG_SND_OMAP_SOC_RX51=y).
[1] http://meego.gitorious.org/meego-os-base/kernel-source/blobs/master/config-arm-n900
-- Felipe Contreras
| |