Messages in this thread | | | Subject | Re: [RFC/RFT PATCH] sched: automated per tty task groups | From | Mike Galbraith <> | Date | Tue, 19 Oct 2010 11:42:08 +0200 |
| |
On Tue, 2010-10-19 at 11:29 +0200, Peter Zijlstra wrote: > On Tue, 2010-10-19 at 11:16 +0200, Mike Galbraith wrote: > > + read_lock_irqsave(&tasklist_lock, flags); > > + > > + rcu_read_lock(); > > + for_each_process(p) { > > + tg = task_group(p); > > + tty_sched_move_task(p, tg); > > + list_for_each_entry_rcu(t, &p->thread_group, thread_group) { > > + tty_sched_move_task(t, tg); > > + } > > + } > > + rcu_read_unlock(); > > + > > + read_unlock_irqrestore(&tasklist_lock, flags); > > I don't think you need to disable IRQs for tasklist lock, nor do I think > you actually need it.
OK, thanks. (No such thing as too paranoid;)
-Mike
| |