Messages in this thread | | | Date | Tue, 19 Oct 2010 03:11:25 +0200 | From | Christoph Hellwig <> | Subject | Re: [PATCH 1/1] hostfs: fix UML crash |
| |
On Mon, Oct 18, 2010 at 01:02:08PM -0700, Andrew Morton wrote: > > > > > > Is there any reason for hostfs to be playing with the f_spare field at all?
No, there is no reason at all. do_statfs is only called by hostfs_statfs, which is the hostfs implementation of ->statfs. zeroing of the spare fields is done by common code (vfs_statfs_native).
Can you submit a patch to just remove the spare_out argument to do_statfs?
> 365b1818 added f_flags to `struct statfs' but didn't carry that over to > `struct compat_statfs' and hence didn't copy f_flags over into > compat_statfs. Deliberate, or oversight?
Oversight.
| |