lkml.org 
[lkml]   [2010]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] hostfs: fix UML crash
On Mon, Oct 18, 2010 at 01:02:08PM -0700, Andrew Morton wrote:
> > >
> > > Is there any reason for hostfs to be playing with the f_spare field at all?

No, there is no reason at all. do_statfs is only called by
hostfs_statfs, which is the hostfs implementation of ->statfs. zeroing
of the spare fields is done by common code (vfs_statfs_native).

Can you submit a patch to just remove the spare_out argument to do_statfs?

> 365b1818 added f_flags to `struct statfs' but didn't carry that over to
> `struct compat_statfs' and hence didn't copy f_flags over into
> compat_statfs. Deliberate, or oversight?

Oversight.


\
 
 \ /
  Last update: 2010-10-19 03:15    [W:0.100 / U:0.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site