Messages in this thread | | | Date | Mon, 18 Oct 2010 00:05:51 -0700 (PDT) | From | Alex Dubov <> | Subject | Re: [PATCH 0/6] Results of my work on memorystick subsystem |
| |
--- On Sun, 17/10/10, Maxim Levitsky <maximlevitsky@gmail.com> wrote:
> > > > Here is a result of lot of work I did improving the > memorystick > > subsystem and its drivers. > Comments? > Flames? > Suggestions? >
My opinion is, that in the current form your patches are completely unworkable.
I suggest a following approach, consisting of 3 clearly separated steps:
Step 1 - a set of functional patches to jmicron driver. Step 2 - a set of functional patches to mspro driver. Step 3 - common code elimination (the whole thing is not that large, it can tolerate some code duplication).
When we done with this, we can discuss whatever cosmetic changes you want to do (moving stuff around and , possibly, renaming, which I don't see as necessary at all).
| |