lkml.org 
[lkml]   [2010]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] x86: Cleanup TIF value gaps in shift range
On Mon, Oct 18, 2010 at 01:48:10PM -0700, H. Peter Anvin wrote:
> On 10/18/2010 01:35 PM, Frederic Weisbecker wrote:
> > 9, 19 and 26 values are missing from the TIF shift range, probably
> > due to flags that were removed by the past. Now repack the range
> > so that we can quickly retrieve the remaining free shift slots.
> >
> > But take care of keeping the seperation between high and low bits
> > as some masks are created on top of this boundary.
> >
>
> What is the point of this? All it seems is that it would make stupid
> debugging mistakes possible because someone looks at the values from the
> wrong kernel.
>
> Feel free to put comments in:
>
> /* 9 - unused - was TIF_xxx */
>
> ... but I think gratuitous compaction is a really bad idea.
>
> Nacked-by: H. Peter Anvin <hpa@zytor.com>


I just felt the current state was messy. But I understand your reasons,
just forget those patches.

Thanks.



\
 
 \ /
  Last update: 2010-10-18 23:19    [from the cache]
©2003-2011 Jasper Spaans