lkml.org 
[lkml]   [2010]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] checkpatch: allow single space before labels
From
Date
On Mon, 2010-10-18 at 14:21 -0400, Mike Frysinger wrote:
> On Mon, Oct 18, 2010 at 10:58, Peter Zijlstra wrote:
> > On Mon, 2010-10-18 at 10:54 -0400, Ted Ts'o wrote:
> >> Note that there is absolutely nothing about how labels should be
> >> indented in CodingStyle at all, and I very much resist code
> >> straightjackets being imposed by checkpatch.pl implementors.
> >>
> >> Can we please stop this nonsense?
> >
> > 1) ignoring checkpatch over taste is good
> > 2) by 1) its impossible to get checkpatch right
> > 3) therefore pure checkpatch patches are nonsense
>
> sounds like an ACK for Joe's patch

No its quite the reverse, by acking joe's patch I loose checkpatch
functionality I like.

There are checks I don't really like, for those I simply ignore its
output, I suggest others do the same.


\
 
 \ /
  Last update: 2010-10-18 20:35    [from the cache]
©2003-2011 Jasper Spaans