lkml.org 
[lkml]   [2010]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/3] drivers/staging/cx25821: Use kstrdup
From
Date
On Mon, 2010-10-18 at 19:44 +0200, Julia Lawall wrote:
> On Mon, 18 Oct 2010, Joe Perches wrote:
>
> > Perhaps it's more readable code to recheck the
> > field name flag and introduce a temporary
> > char *fname so the slightly unusual reuse of
> > field = kstrdup(field, GFP)
> > becomes
> > field = kstrdup(fname, GFP)
>
> Before I had a local variable filename. I preferred that because I felt
> uneasy about putting both statically and dynamically allocated memory in
> the same field. But it does mean adding a new local variable.

I think readability is better using a temporary.

> I'm not sure to understand "recheck the field name flag", though.

Sorry, poor wording. I meant using this style:

if (field && *field)
foo
else if (field)
bar
else
baz

instead of:

if (field) {
if (*field)
foo
else
bar
} else
baz




\
 
 \ /
  Last update: 2010-10-18 19:59    [W:0.085 / U:0.252 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site