Messages in this thread | | | Date | Mon, 18 Oct 2010 17:10:20 +0200 | From | Clemens Ladisch <> | Subject | Re: [PATCH 2/8] char: hpet: fix information leak to userland |
| |
Vasiliy Kulikov wrote: > Structure info is copied to userland with some padding fields unitialized. > It leads to leaking of stack memory.
> --- a/drivers/char/hpet.c > +++ b/drivers/char/hpet.c > @@ -581,6 +581,7 @@ hpet_ioctl_common(struct hpet_dev *devp, int cmd, unsigned long arg, > break; > case HPET_INFO: > { > + memset(info, 0, sizeof(*info)); > if (devp->hd_ireqfreq) > info->hi_ireqfreq = > hpet_time_div(hpetp, devp->hd_ireqfreq);
This makes the following assignment "info->hi_ireqfreq = 0;" superfluous.
Regards, Clemens
| |