lkml.org 
[lkml]   [2010]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/8] char: hpet: fix information leak to userland
Vasiliy Kulikov wrote:
> Structure info is copied to userland with some padding fields unitialized.
> It leads to leaking of stack memory.

> --- a/drivers/char/hpet.c
> +++ b/drivers/char/hpet.c
> @@ -581,6 +581,7 @@ hpet_ioctl_common(struct hpet_dev *devp, int cmd, unsigned long arg,
> break;
> case HPET_INFO:
> {
> + memset(info, 0, sizeof(*info));
> if (devp->hd_ireqfreq)
> info->hi_ireqfreq =
> hpet_time_div(hpetp, devp->hd_ireqfreq);

This makes the following assignment "info->hi_ireqfreq = 0;" superfluous.


Regards,
Clemens


\
 
 \ /
  Last update: 2010-10-18 17:11    [W:0.033 / U:1.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site