Messages in this thread | | | Date | Mon, 18 Oct 2010 09:22:29 -0500 | From | Eric Sandeen <> | Subject | Re: [PATCH] ext3: Remove misplaced BUFFER_TRACE() in ext3_truncate() |
| |
Namhyung Kim wrote: > Signed-off-by: Namhyung Kim <namhyung@gmail.com> > --- > fs/ext3/inode.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/fs/ext3/inode.c b/fs/ext3/inode.c > index 5e0faf4..90a9c3d 100644 > --- a/fs/ext3/inode.c > +++ b/fs/ext3/inode.c > @@ -2530,7 +2530,6 @@ void ext3_truncate(struct inode *inode) > */ > } else { > /* Shared branch grows from an indirect block */ > - BUFFER_TRACE(partial->bh, "get_write_access"); > ext3_free_branches(handle, inode, partial->bh, > partial->p, > partial->p+1, (chain+n-1) - partial);
As long as you're doing these cleanups, you may as well eyeball ext4 to see whether the same issues exist; in the case above, it does, and the exact same patch (modulo ext3/ext4 changes) applies.
No real point in getting ext3 fixed up and leaving ext4 behind...
Thanks, -Eric
| |