Messages in this thread Patch in this message | | | From | Vasiliy Kulikov <> | Subject | [PATCH 6/8] char: synclink: fix information leak to userland | Date | Sun, 17 Oct 2010 18:41:32 +0400 |
| |
Structure new_line is copied to userland with some padding fields unitialized. It leads to leaking of stack memory.
Signed-off-by: Vasiliy Kulikov <segooon@gmail.com> --- Compile tested.
drivers/char/synclink.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/char/synclink.c b/drivers/char/synclink.c index 3a6824f..abd0867 100644 --- a/drivers/char/synclink.c +++ b/drivers/char/synclink.c @@ -7846,6 +7846,8 @@ static int hdlcdev_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd) if (cmd != SIOCWANDEV) return hdlc_ioctl(dev, ifr, cmd); + memset(&new_line, 0, size); + switch(ifr->ifr_settings.type) { case IF_GET_IFACE: /* return current sync_serial_settings */ -- 1.7.0.4
| |