lkml.org 
[lkml]   [2010]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[tip:perf/core] oprofile, ARM: Release resources on failure
    Commit-ID:  81771974ae49bf79aab60c42eac7a6d730a9ef2b
    Gitweb: http://git.kernel.org/tip/81771974ae49bf79aab60c42eac7a6d730a9ef2b
    Author: Robert Richter <robert.richter@amd.com>
    AuthorDate: Wed, 29 Sep 2010 16:52:25 +0200
    Committer: Robert Richter <robert.richter@amd.com>
    CommitDate: Mon, 11 Oct 2010 19:27:10 +0200

    oprofile, ARM: Release resources on failure

    This patch fixes a resource leak on failure, where the
    oprofilefs and some counters may not released properly.

    Signed-off-by: Robert Richter <robert.richter@amd.com>
    Acked-by: Will Deacon <will.deacon@arm.com>
    Cc: linux-arm-kernel@lists.infradead.org
    Cc: <stable@kernel.org> # .35.x
    LKML-Reference: <20100929145225.GJ13563@erda.amd.com>
    Signed-off-by: Ingo Molnar <mingo@elte.hu>
    ---
    drivers/oprofile/oprofile_perf.c | 1 +
    1 files changed, 1 insertions(+), 0 deletions(-)

    diff --git a/drivers/oprofile/oprofile_perf.c b/drivers/oprofile/oprofile_perf.c
    index ebb40cb..f3d3df2 100644
    --- a/drivers/oprofile/oprofile_perf.c
    +++ b/drivers/oprofile/oprofile_perf.c
    @@ -84,6 +84,7 @@ static int op_create_counter(int cpu, int event)
    if (IS_ERR(pevent)) {
    ret = PTR_ERR(pevent);
    } else if (pevent->state != PERF_EVENT_STATE_ACTIVE) {
    + perf_event_release_kernel(pevent);
    pr_warning("oprofile: failed to enable event %d "
    "on CPU %d\n", event, cpu);
    ret = -EBUSY;

    \
     
     \ /
      Last update: 2010-10-16 18:35    [W:0.024 / U:1.544 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site