lkml.org 
[lkml]   [2010]   [Oct]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRE: [PATCH 1/3] drivers: misc: ad525x_dpot: Fix typo in spi write16 and write24 transfer counts
Andrew Morton wrote on 2010-10-15:
> On Thu, 14 Oct 2010 10:59:46 +0200
> <michael.hennerich@analog.com> wrote:
>
>> From: Michael Hennerich <michael.hennerich@analog.com>
>>
>>
>> Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
>> ---
>> drivers/misc/ad525x_dpot-spi.c | 4 ++--
>> 1 files changed, 2 insertions(+), 2 deletions(-)
>> diff --git a/drivers/misc/ad525x_dpot-spi.c
>> b/drivers/misc/ad525x_dpot-spi.c index b8c6df9..6cfcb63 100644
>> --- a/drivers/misc/ad525x_dpot-spi.c
>> +++ b/drivers/misc/ad525x_dpot-spi.c
>> @@ -53,13 +53,13 @@ static int write8(void *client, u8 val) static
>> int write16(void *client, u8 reg, u8 val) {
>> u8 data[2] = {reg, val};
>> - return spi_write(client, data, 1);
>> + return spi_write(client, data, 2);
>> }
>>
>> static int write24(void *client, u8 reg, u16 val) {
>> u8 data[3] = {reg, val >> 8, val};
>> - return spi_write(client, data, 1);
>> + return spi_write(client, data, 3);
>> }
>>
>> static int read8(void *client)
>
> What are the runtime effects of this change?

Hi Andrew,

This is a bug fix. Some SPI connected devices using
16/24 bit accesses, previously failed, now work.

This typo slipped in after testing, during some restructuring.

Greetings,
Michael

Analog Devices GmbH Wilhelm-Wagenfeld-Str. 6 80807 Muenchen
Sitz der Gesellschaft Muenchen, Registergericht Muenchen HRB 4036 Geschaeftsfuehrer Thomas Wessel, William A. Martin, Margaret Seif



\
 
 \ /
  Last update: 2010-10-15 09:33    [from the cache]
©2003-2011 Jasper Spaans