Messages in this thread | | | Date | Thu, 14 Oct 2010 08:27:01 -0600 | From | Matthew Wilcox <> | Subject | Re: [PATCH] bitops.h: Widen BIT macro to support 64-bit types |
| |
On Thu, Oct 14, 2010 at 02:12:30PM +0200, Borislav Petkov wrote: > From: Matthew Wilcox <matthew@wil.cx> > Date: Thu, Oct 14, 2010 at 07:12:13AM -0400 > > > On Thu, Oct 14, 2010 at 12:58:55PM +0200, Borislav Petkov wrote: > > > #ifdef __KERNEL__ > > > -#define BIT(nr) (1UL << (nr)) > > > +#define BIT(nr) (U64_C(1) << (nr)) > > > > Why not just use 1ULL instead? > > Wanted to be __ASSEMBLY__ safe.
Admirable, but the entire file is __ASSEMBLY__ unsafe at this point, so I don't see the point.
-- Matthew Wilcox Intel Open Source Technology Centre "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step."
| |